Repository navigation
feat(implement-change): add verify mode for work written with no plan - #135
Merged
Merged
Conversation
- Add `implement-change verify [goal]`: runs the build's review wave on the branch's diff with `Plan: none` and a one-line goal as the brief, asking for the goal once when none is given - Let implementation-reviewer and focused-reviewer judge goal and scope against the brief when there is no plan - Bump implement-change to 1.20.0 - Document verify in README, GUIDE.md and docs/design.md; narrow the ROADMAP route item and defer carrying a declined finding's reason between waves, with the sandbox results - Add sandbox scenarios verify-adhoc-swallowed, verify-asks-goal and trigger-implement-change-verify Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review wave, the implementation reviewer and the focused reviewers looping until clean, is what implement-change's build and pr-fix run before a change is called done. Nothing else reaches it, so code written without a plan, by hand or in an ad hoc session, gets no plugin review before it is committed. I covered that gap with a personal review skill, which meant the plugin's wave reached colleagues with only sandbox evidence behind it. This adds
/lasp-dev:implement-change verify [goal], so work written with no plan goes through the same wave and the personal skill can retire.How verify works
Verify takes the branch's diff (the working tree plus commits since the merge base with the default branch), asks once for a one-line goal when none is given, and runs the wave with
Plan: noneand the goal as the brief. The implementation reviewer judges goal and scope against the brief instead of a plan. It is a mode of implement-change rather than a new skill because the build hook, the build record and pr-create's reading ofPlan: nonealready handle an implement-change run, so verify ends at step 9's diff gate and goes on to commit and pr-create behind their own gates. Verify runs no git write itself; the wave can edit the working tree to fix a blocking finding, and verify's opening line says so.At a deep depth floor verify still runs the wave, records
Depth: deep, and names the planned build as the alternative at the close. It never lowers to light.Deferred: declined findings carried between waves
This branch first also carried a declined finding's reason into later waves. On Haiku, main already kept the code a person declined to change in 10 of 10 runs, against 9 of 10 with the change; its gain was a written record and a wrong reason marked disputed, not enough to merge on. It moved to ROADMAP with the numbers.
Limits
workand the session-start line do not know a verify build yet; that stays in ROADMAP.Origin: the maintainer's comparison of personal review skills with the plugin's; the plugin's wave had no entry for work written with no plan.
Sandbox: new scenarios on the branch, read by hand: verify-adhoc-swallowed 3/3, verify-asks-goal 5/5 (its
--checkfailed on an expect a slash command cannot meet, since removed). Regression with--check: review-specified-retry and review-swallowed-exception 10/10 on main and 10/10 on the branch; implement-change-keeps-todo unchanged.Canary: not yet run.
🤖 Generated with Claude Code. AI assistance level: 4/5.